Skip to content

Feature: Switch to Typespec contract description model #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Aug 15, 2025
Merged

Conversation

germanosin
Copy link
Member

@germanosin germanosin commented Jun 9, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
image

@germanosin germanosin requested review from a team as code owners June 9, 2025 22:16
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed labels Jun 9, 2025
@germanosin germanosin marked this pull request as draft June 9, 2025 22:16
@kapybro kapybro bot removed the status/triage Issues pending maintainers triage label Jun 9, 2025
@germanosin germanosin changed the title Use typespec contracts FE: Switch to Typespec contract description model Jun 11, 2025
@germanosin germanosin marked this pull request as ready for review August 7, 2025 14:28
@germanosin germanosin requested a review from a team as a code owner August 7, 2025 14:28
@germanosin germanosin changed the title FE: Switch to Typespec contract description model Feature: Switch to Typespec contract description model Aug 7, 2025
@germanosin germanosin added this to the 1.4 milestone Aug 7, 2025
@germanosin germanosin added type/feature A brand new feature scope/frontend Related to frontend changes scope/backend Related to backend changes labels Aug 7, 2025
@@ -40,8 +40,8 @@
"start": "vite",
"dev": "vite",
"compile": "pnpm gen:sources && tsc --noEmit",
"gen:sources": "rimraf ./src/generated-sources && openapi-generator-cli generate",
"build": "rimraf ./src/generated-sources && openapi-generator-cli generate && tsc --noEmit && vite build",
"gen:sources": "rimraf ./src/generated-sources && cd ../contract-typespec/api && pnpm install && pnpm build && cd ../../frontend && openapi-generator-cli generate",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check that this works on windows™

@Nilumilak could you try out building this?

@github-project-automation github-project-automation bot moved this from Todo to Changes requested in Release 1.4 Aug 15, 2025
@Haarolean Haarolean self-requested a review August 15, 2025 11:58
@Haarolean Haarolean moved this from Changes requested to PR Approved in Release 1.4 Aug 15, 2025
@germanosin germanosin merged commit d09fe32 into main Aug 15, 2025
18 checks passed
@germanosin germanosin deleted the typespec branch August 15, 2025 12:00
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Release 1.4 Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/feature A brand new feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants